Fixes for #153 #155
Open
Fixes for #153 #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement SQL_ATTR_CURSOR_SCROLLABLE as a writable attribute in PGAPI_SetStmtAttr. Setting SQL_SCROLLABLE maps to SQL_CURSOR_STATIC, and SQL_NONSCROLLABLE maps to SQL_CURSOR_FORWARD_ONLY. Previously the driver unconditionally rejected this attribute with SQL_ERROR, even though it fully supports scrollable cursors via SQL_ATTR_CURSOR_TYPE. Add cursor-scrollable regression test to verify the behavior.
Return SQL_ERROR with SQLSTATE HYC00 when an application attempts to enable asynchronous execution, which the driver does not support. Previously the driver silently ignored the request, returning SQL_SUCCESS, which misled applications into believing async was active. Setting SQL_ASYNC_ENABLE_OFF remains a successful no-op. Add async-enable regression test to verify the behavior.
Rec 3: Return SQLSTATE HY096 for invalid SQLGetInfo info types instead of HYC00. Add CONN_INVALID_INFO_TYPE error code (215) mapped to HY096. Use it in PGAPI_GetInfo for unrecognized info type values. Rec 4: Return SQLSTATE HY092 for invalid SQLSetConnectAttr attributes instead of HY000. Add explicit SQLSTATE mapping for the existing CONN_OPTION_NOT_FOR_THE_DRIVER error code to HY092. Previously this code had no mapping and fell through to the generic HY000 default.
Add odbc-conformance test that verifies: - SQLGetInfo with invalid info type returns SQLSTATE HY096 - SQLSetConnectAttr with invalid attribute returns SQLSTATE HY092 Also register all new tests (async-enable, cursor-scrollable, odbc-conformance) in the test/tests list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the four recommendations outlined by Claude after reviewing the ODBC Crusher report referenced in #153.
ODBC Conformance Improvements
This PR addresses 4 low-severity ODBC conformance issues identified by ODBC Crusher v0.4.5 testing against psqlodbc v16.00.0000, as documented in
docs/postgresql_ODBC_RECOMMENDATIONS.md.Changes
1. Implement
SQL_ATTR_CURSOR_SCROLLABLEsetter (Level 2)pgapi30.c: ChangedSQL_ATTR_CURSOR_SCROLLABLEfrom unconditionally rejected to a functional setterSQL_SCROLLABLE→SQL_CURSOR_STATIC,SQL_NONSCROLLABLE→SQL_CURSOR_FORWARD_ONLYSQL_ATTR_CURSOR_TYPE2. Properly reject unsupported async execution
options.c: ReturnSQL_ERROR(SQLSTATEHYC00) whenSQL_ASYNC_ENABLE_ONis requestedSQL_SUCCESSwhile silently ignoring the setting, violating the principle of least surpriseSQL_ASYNC_ENABLE_OFFremains a successful no-op3. Fix SQLSTATE for invalid
SQLGetInfotypesCONN_INVALID_INFO_TYPE(215) error codeinfo.c+environ.c: ReturnHY096(invalid information type) instead ofHYC00for unrecognized info types4. Fix SQLSTATE for invalid connection attributes
environ.c: Added explicitCONN_OPTION_NOT_FOR_THE_DRIVER→HY092mappingHY000; now returns spec-compliantHY092(invalid attribute/option identifier)Testing
cursor-scrollable-test,async-enable-test,odbc-conformance-testImpact
Low-severity spec compliance improvements. No breaking changes. The driver already supported all underlying functionality; these changes improve error reporting and API surface consistency with the ODBC 3.x specification.